Downgrade Highway to latest released version (1.0.7)#25446
Downgrade Highway to latest released version (1.0.7)#25446rgommers merged 1 commit intonumpy:mainfrom
Conversation
a37847e to
fd3c6cd
Compare
|
Thanks @Mousius. Let's let CI complete here, and then a rebase should make the aarch64 wheel builds on Cirrus run too. I'd be curious to see whether those pass with this update-to-latest, even if we decide to go back to the 1.0.7 release instead in the end. |
I don't think we can go back to 1.0.7, it's quite old and we've bumped a few times for fixes already. Potentially worth getting this in and then latching onto the next version release? |
fd3c6cd to
b6866f8
Compare
|
Everything seems happy here, so I've disabled non-Cirrus jobs in the rerun.
Sounds reasonable to me. |
|
Looks like less errors, but still some errors. I'll try and take a look at this tomorrow. |
|
Thanks! Building locally on a manylinux aarch64 container will probably be more helpful that in CI. For macOS that's possible too with the Tart VM, see #25012 (comment). |
b6866f8 to
d40da6c
Compare
We had to pull in some git commits after the initial Highway merge, but it makes way more sense to use their well tested versions 😸 Hopefully fixes numpy#25445
d40da6c to
96000c1
Compare
|
@rgommers I checked out I got mega test failures in Apologies for the CI resource usage 🙀 I had to re-rebase; hopefully, those jobs get shut down. |
No worries about this one at all. We try to be careful, but it's secondary to getting things to work:) We burned $15 in ~48 hours, which is fine - it's more the admin hassle of it than anything else. |
We had to pull in some git commits after the initial Highway merge, but
it makes way more sense to use their well tested versions 😸
Hopefully fixes #25445