CI: show meson-log.txt in Cirrus wheel builds#25440
Merged
rgommers merged 1 commit intonumpy:mainfrom Dec 21, 2023
Merged
Conversation
To do this, we need to be able to locate the log file in a fixed location, hence the need to add `build-dir=build` to the flags passed to meson-python. And to make that work, it turns out pypa/build is the better build front-end to use. It's also going to be the future default for cibuildwheel, so this change makes sense anyway. [skip azp] [skip circle]
charris
approved these changes
Dec 20, 2023
Member
Author
|
eh oh, trouble with Trying to figure out if this happened before, it should be unrelated to this PR. |
Member
Author
|
A search for that error comes up empty, however we haven't run these wheel builds in 1 months and 8 days I think (that was the last nightly upload for aarch64 to https://anaconda.org/scientific-python-nightly-wheels/numpy/files). That last successful build was before the initial merge of |
Member
|
I guess one issue is that we don't have visibility for when a nightly wheel build fails. |
Member
Author
|
Indeed, that is pretty unhelpful. We could add something like https://cirrus-ci.org/guide/notifications/#email-action, only for failures on |
Member
Yes and no. I'd rather have a visible badge on the scipy/scipy GH landing page rather than getting emailed everyday. |
Member
Author
That would work too perhaps - but I personally am unlikely to notice. After the 2.0 branch split we'll probably go back to weekly cron job triggers instead of daily, so emails wouldn't be too bad. |
Member
Author
|
The Moving ahead with this change, working towards getting the new Accelerate wheel builds in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this, we need to be able to locate the log file in a fixed location, hence the need to add
build-dir=buildto the flags passed to meson-python. And to make that work, it turns outpypa/buildis the better build front-end to use. It's also going to be the future default forcibuildwheel, so this change makes sense anyway.Extracted from gh-25012, this is a standalone change that is mergeable.
[wheel build]