BLD: remove -fno-strict-aliasing, --strip-debug from cibuildwheel config#25439
Merged
charris merged 1 commit intonumpy:mainfrom Dec 20, 2023
Merged
BLD: remove -fno-strict-aliasing, --strip-debug from cibuildwheel config#25439charris merged 1 commit intonumpy:mainfrom
-fno-strict-aliasing, --strip-debug from cibuildwheel config#25439charris merged 1 commit intonumpy:mainfrom
Conversation
… config It's already included in the top-level `meson.build` file, which is more correct. See numpygh-25004 for where `-fno-strict-aliasing` came from. Also clean up the `-Wl,--strip-debug` flag, it's unused since the buildtype is release and there is no debug info in the binaries. [skip ci]
rgommers
force-pushed
the
clean-wheel-cflags
branch
from
e813d4a to
1d01aae
Compare
charris
approved these changes
Dec 20, 2023
Member
|
Thanks Ralf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already included in the top-level
meson.buildfile, which is more correct. See gh-25004 for where-fno-strict-aliasingcame from.Also clean up the
-Wl,--strip-debugflag, it's unused since the buildtype is release and there is no debug info in the binaries.(not triggering wheel builds, since this has been tested multiple times in gh-25012, and also in gh-25255)