-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
MAINT: Adapt npt._GenericAlias to Python 3.11 types.GenericAlias changes #21605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There's a very high bar for changes after |
Deliberate divergence w.r.t. CPython
Then let's hope python/cpython#92335 will remain the last of it, as it just introduced a new |
|
What's going on with the |
Good point. The respective PR for 3.11 is not even merged yet though. |
I couldn't find |
It's just been added in this PR via 4682699. |
Don't know, the error is new. I was going to rerun it. The test sets up its own docker run. |
|
I think there should be a call to numpy/.github/workflows/build_test.yml Lines 283 to 285 in d75e7d8
|
Let me give it a shot. |
|
Does this need a backport? We will be supporting Python 3.11 in NumPy 1.23 after the first Python rc. |
Good point, yes. Though maybe we should a bit until #21308 is merged with all the remaining py3.11 changes? |
OK, I marked both that PR and this for 1.23.1, there is no rush for 3.11. |
|
Well, the last CI job is still spitting out HTTP errors when installing openblas, but besides that everything is finally green. |
|
LGTM. I reran the macOS job and it passed. Thanks @BvB93 |
npt._GenericAlias backport to Python 3.11 types.GenericAlias changes
CC @EwoutH
Follow up on #21543, xref #21308
Adapt
npt._GenericAliasto the various PEP 646-related changes introduced intypes.GenericAlias, notably the introduction of three new attributes and/or methods:__iter____unpacked____typing_unpacked_tuple_args__Note that
types.GenericAliasstill seems to updated on a regular basis in the current 3.11 dev cycle (so more changes may or may not be necessary in the future), but this should be enough to get things running again for #21308.