ENH: Speed up default where in the reduce-like method
#17904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a 20%-30% overhead, and thus the largest chunk of slowdown incurred by adding the `where` argument. Most other places have fast-paths for `where=True`, this one also should have it. The additional argument does slow down the function versions a bit more than this, but that is to be expected probably (it has to build a new argument dict, at some point we might want to move this to C, but that seems worth much more with FASTCALL logic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17896.
This is a small followup of gh-15852. I realize these are micro-optimizations, but... Half the point of this file is probably a micro-optimization for any/all by unpacking the kwargs, and this does give a 20-30% boost for very small arrays. We should probably add some "tiny array" benchmarks.
Anyway, on the grand scheme of things, this may not matter, but they are also super simple changes.
Fixes gh-17894