Skip to content

🚑 Fix/Only cache GET requests #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mortaro merged 4 commits into from
Jan 23, 2023
Merged

🚑 Fix/Only cache GET requests #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9925349
Merge pull request #297 from nullstack/next
Mortaro Dec 8, 2022
8d41e5c
Merge pull request #300 from nullstack/unstable-next
Mortaro Dec 28, 2022
268042d
Merge pull request #301 from nullstack/next
Mortaro Dec 28, 2022
9b4b24e
Fix: Only cache on GET requests
flaviokicis Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workers/dynamicFetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
function dynamicStrategy(event) {
event.waitUntil(
(async function () {
if (event.request.method !== 'GET') return
const url = new URL(event.request.url)
for (const matcher of self.context.worker.staleWhileRevalidate) {
if (match(matcher, url)) {
Expand All @@ -13,7 +14,6 @@ function dynamicStrategy(event) {
}
}
if (url.origin !== location.origin) return
if (event.request.method !== 'GET') return
if (url.pathname.indexOf('/nullstack/') > -1) {
return event.respondWith(networkFirst(event))
}
Expand Down
2 changes: 1 addition & 1 deletion workers/staticFetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
function staticStrategy(event) {
event.waitUntil(
(async function () {
if (event.request.method !== 'GET') return
const url = new URL(event.request.url)
for (const matcher of self.context.worker.staleWhileRevalidate) {
if (match(matcher, url)) {
Expand All @@ -13,7 +14,6 @@ function staticStrategy(event) {
}
}
if (url.origin !== location.origin) return
if (event.request.method !== 'GET') return
if (url.pathname.indexOf('/nullstack/') > -1) {
return event.respondWith(networkFirst(event))
}
Expand Down