Skip to content

Fix ssg params#218

Merged
Mortaro merged 1 commit intostyle-reloadfrom
fix-ssg-params
Apr 28, 2022
Merged

Fix ssg params#218
Mortaro merged 1 commit intostyle-reloadfrom
fix-ssg-params

Conversation

@Mortaro
Copy link
Copy Markdown
Member

@Mortaro Mortaro commented Apr 28, 2022

No description provided.

@Mortaro Mortaro changed the base branch from master to next April 28, 2022 01:35
@Mortaro Mortaro changed the base branch from next to style-reload April 28, 2022 01:36
@Mortaro Mortaro merged commit 43f76a4 into style-reload Apr 28, 2022
@GuiDevloper
Copy link
Copy Markdown
Member

GuiDevloper commented Apr 28, 2022

Even organized the ternary while doing a deep view:

const isSSG = scope.context.environment.mode === 'ssg';
const key = node.attributes.key ? node.attributes.key : (
  generateKey(node, depth) + (
    node.attributes.route ? (
       isSSG ? scope.context.router.path : scope.context.router.url
    ) : ''
  )
);
if (
  ...
  !isSSG
) {

But still, a error persists without being able to find the origin.

Steps to reproduce

  • Have a component under /home router

  • Going to that route from a tag/reloading it happens (I'm logging key from the code above):
    error1

  • After CTRL+F5 (or add trailing slash at url), all solved 👀
    error2

@Mortaro Mortaro deleted the fix-ssg-params branch April 30, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants