Little webpack config improvements#193
Merged
Mortaro merged 2 commits intonullstack:unstable-nextfrom Apr 16, 2022
Merged
Conversation
In lack of `input` flag webpack just targets the current directory
Some pkgs paths become obscure in some environments, e.g. `pnpm install`, `require.resolve` always finds wherever they are installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with each commit description, some notes:
In day-to-day and custom environments, the
inputflag becomes a problem/unpredictable, e.g. when using pnpm the path from config to my project is exotic, and we already depend on polemiccwd()at builders, so.. :)We're depending on whatever the webpack internal resolve is, being unpredictable and breaks on custom environments, e.g. pnpm packages and their exotic paths.