Skip to content

Next #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mortaro merged 9 commits into from
Mar 8, 2022
Merged

Next #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6776323
excluded console from NodePolyfillPlugin
LoTerence Mar 1, 2022
2f23b30
testing new webpack polyfill config
LoTerence Mar 4, 2022
302b025
excluded console, added console fallback
LoTerence Mar 4, 2022
7ddd128
remove unused code
LoTerence Mar 5, 2022
be38c58
Merge pull request #1 from LoTerence/polyfill-test-fix
LoTerence Mar 5, 2022
8006ae2
Removed polyfill console feature and test
LoTerence Mar 7, 2022
88d0b75
removed fallback consoles
LoTerence Mar 8, 2022
af60661
Merge pull request #188 from LoTerence/polyfill-test
Mortaro Mar 8, 2022
b95e279
:bookmark: nullstack 0.14.3
Mortaro Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nullstack",
"version": "0.14.2",
"version": "0.14.3",
"description": "Full-stack Javascript Components for one-dev armies",
"main": "nullstack.js",
"author": "Mortaro",
Expand All @@ -25,7 +25,7 @@
"babel-loader": "^8.0.5",
"babel-plugin-transform-decorators-legacy": "^1.3.5",
"body-parser": "^1.19.0",
"commander": "^8.1.0",
"commander": "^8.3.0",
"cors": "^2.8.5",
"css-loader": "^6.6.0",
"dotenv": "^8.2.0",
Expand Down
2 changes: 0 additions & 2 deletions tests/src/Polyfill.njs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import assert from 'assert';
import buffer from 'buffer';
import console from 'console';
import constants from 'constants';
import crypto from 'crypto';
import domain from 'domain';
Expand Down Expand Up @@ -35,7 +34,6 @@ class Polyfill extends Nullstack {
data-buffer-global={this.buffer}
data-assert={typeof assert}
data-buffer={typeof buffer}
data-console={typeof console}
data-constants={typeof constants}
data-crypto={typeof crypto}
data-domain={typeof domain}
Expand Down
6 changes: 0 additions & 6 deletions tests/src/Polyfill.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ describe('Polyfill', () => {
expect(element).toBeTruthy();
});

test('client has a polyfill for node console', async () => {
await page.waitForSelector('[data-console="object"]');
const element = await page.$('[data-console="object"]');
expect(element).toBeTruthy();
});

test('client has a polyfill for node constants', async () => {
await page.waitForSelector('[data-constants="object"]');
const element = await page.$('[data-constants="object"]');
Expand Down
4 changes: 3 additions & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ function client(env, argv) {
new MiniCssExtractPlugin({
filename: "client.css"
}),
new NodePolyfillPlugin()
new NodePolyfillPlugin({
excludeAliases: ["console"]
})
]
if (argv.environment === 'production') {
plugins.push(new PurgecssPlugin({
Expand Down