Skip to content

Add tests for html-injected links wrongly refreshing #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mortaro merged 1 commit into from
Feb 15, 2022
Merged

Add tests for html-injected links wrongly refreshing #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/src/RoutesAndParams.njs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ class RoutesAndParams extends Nullstack {

eventTriggered = false;
paramHydrated = false;
shownLink = true;
htmlLinkBtn = '';

hydrate(context) {
const { router, params } = context;
this.paramHydrated = params.id === 'a';
window.addEventListener(router.event, () => {
context.eventTriggered = true;
});
this.shownLink = !params.hideLink;
this.htmlLinkBtn = 'click';
}

renderOther({ params }) {
Expand All @@ -29,6 +33,22 @@ class RoutesAndParams extends Nullstack {
)
}

renderInnerHTML({ params, route }) {
const html = `
<a href="${route}?hideLink=${params.hideLink}"> innerHTML </a>
`
return (
<div data-shown-link={this.shownLink}>
<button
onclick={{shownLink: true, htmlLinkBtn: 'clicked'}}
data-show-link={this.htmlLinkBtn}
html={this.htmlLinkBtn}
/>
<div html={this.shownLink ? html : ''} />
</div>
)
}

setParamsDate({ params }) {
params.date = new Date('1992-10-16');
}
Expand All @@ -46,6 +66,7 @@ class RoutesAndParams extends Nullstack {
<div data-event-triggered={eventTriggered} />
<div data-router={!!router} />
<div route="/routes-and-params" data-route="/routes-and-params" />
<InnerHTML route="/routes-and-params/inner-html" />
<Other route="/routes-and-params/:id" />
<Wildcard route="/routes-and-params/*" />
<a href="/routes-and-params/a"> a </a>
Expand Down
27 changes: 27 additions & 0 deletions tests/src/RoutesAndParams.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,4 +229,31 @@ describe('RoutesAndParams /routes-and-params?previous=true', () => {
expect(element).toBeTruthy();
});

});

describe('RoutesAndParams /routes-and-params/inner-html', () => {

const htmlRoute = 'routes-and-params/inner-html?hideLink=';

async function redirectAndKeepState(hiddenLink = '') {
await page.goto(`http://localhost:6969/${htmlRoute}${hiddenLink}`);
await page.waitForSelector('[data-show-link="click"]');
await page.click('[data-show-link="click"]');
await page.waitForSelector('[data-show-link="clicked"]');
await page.waitForSelector('[data-shown-link]');
await page.waitForSelector(`[href="/${htmlRoute}${hiddenLink}"]`);
await page.click(`[href="/${htmlRoute}${hiddenLink}"]`);
return page.$('[data-show-link="clicked"]');
}

test('html route injected from start do not refresh', async () => {
const element = await redirectAndKeepState();
expect(element).toBeTruthy();
});

test('html route injected after first render do not refresh', async () => {
const element = await redirectAndKeepState('true');
expect(element).toBeTruthy();
});

});