Replace inexistent rmSync with removeSync on builds#156
Merged
Mortaro merged 1 commit intonullstack:gui-scriptsfrom Jan 22, 2022
Merged
Replace inexistent rmSync with removeSync on builds#156Mortaro merged 1 commit intonullstack:gui-scriptsfrom
rmSync with removeSync on builds#156Mortaro merged 1 commit intonullstack:gui-scriptsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some curious reason,
fs-extraincludesfstypes but not all it's functions.rmSyncis an example, they only use it internally onremoveSyncwith fixed options (recursive&force).Without this change, the alternative builds (ssg & spa) breaks when trying to
rmSyncan old build.btw, it allows Netlify CI to finally build/rebuild a project like our docs:
https://app.netlify.com/sites/nullstack-docs/deploys