Skip to content

Commit 497d8a1

Browse files
committed
Added more tests
1 parent 73d1208 commit 497d8a1

5 files changed

Lines changed: 946 additions & 12 deletions

File tree

‎src/Microsoft.OpenApi/Services/OpenApiParameterComparer.cs‎

Lines changed: 34 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,47 @@ public override void Compare(
4242
return;
4343
}
4444

45-
comparisonContext.GetComparer<OpenApiSchema>().Compare(
46-
sourceParameter?.Schema,
47-
targetParameter?.Schema,
48-
comparisonContext);
49-
5045
WalkAndCompare(
5146
comparisonContext,
5247
OpenApiConstants.Content,
5348
() => comparisonContext
5449
.GetComparer<IDictionary<string, OpenApiMediaType>>()
5550
.Compare(sourceParameter.Content, targetParameter.Content, comparisonContext));
5651

52+
WalkAndCompare(comparisonContext, OpenApiConstants.Description,
53+
() => Compare(sourceParameter.Description, targetParameter.Description, comparisonContext));
54+
55+
WalkAndCompare(comparisonContext, OpenApiConstants.Required,
56+
() => Compare(sourceParameter.Required, targetParameter.Required, comparisonContext));
57+
58+
WalkAndCompare(comparisonContext, OpenApiConstants.Name,
59+
() => Compare(sourceParameter.Name, targetParameter.Name, comparisonContext));
60+
61+
WalkAndCompare(comparisonContext, OpenApiConstants.Deprecated,
62+
() => Compare(sourceParameter.Deprecated, targetParameter.Deprecated, comparisonContext));
63+
64+
WalkAndCompare(comparisonContext, OpenApiConstants.AllowEmptyValue,
65+
() => Compare(sourceParameter.AllowEmptyValue, targetParameter.AllowEmptyValue, comparisonContext));
66+
67+
WalkAndCompare(comparisonContext, OpenApiConstants.Explode,
68+
() => Compare(sourceParameter.Explode, targetParameter.Explode, comparisonContext));
69+
70+
WalkAndCompare(comparisonContext, OpenApiConstants.AllowReserved,
71+
() => Compare(sourceParameter.AllowReserved, targetParameter.AllowReserved, comparisonContext));
72+
73+
WalkAndCompare(comparisonContext, OpenApiConstants.Style,
74+
() => Compare<ParameterStyle>(sourceParameter.Style, targetParameter.Style, comparisonContext));
75+
76+
WalkAndCompare(comparisonContext, OpenApiConstants.In,
77+
() => Compare<ParameterLocation>(sourceParameter.In, targetParameter.In, comparisonContext));
78+
79+
WalkAndCompare(
80+
comparisonContext,
81+
OpenApiConstants.Schema,
82+
() => comparisonContext
83+
.GetComparer<OpenApiSchema>()
84+
.Compare(sourceParameter.Schema, targetParameter.Schema, comparisonContext));
85+
5786
// To Do Add compare for reference object
5887
// To Do Compare Examples
5988
// To Do Compare parameter as IOpenApiExtensible

‎src/Microsoft.OpenApi/Services/OpenApiParametersComparer.cs‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ public override void Compare(
3030
return;
3131
}
3232

33-
if (!sourceParameters.Any() && !targetParameters.Any())
34-
{
35-
return;
36-
}
37-
3833
if (sourceParameters == null || targetParameters == null)
3934
{
4035
comparisonContext.AddOpenApiDifference(
@@ -43,7 +38,7 @@ public override void Compare(
4338
OpenApiDifferenceOperation = OpenApiDifferenceOperation.Update,
4439
SourceValue = sourceParameters,
4540
TargetValue = targetParameters,
46-
OpenApiComparedElementType = typeof(OpenApiParameter),
41+
OpenApiComparedElementType = typeof(IList<OpenApiParameter>),
4742
Pointer = comparisonContext.PathString
4843
});
4944

‎src/Microsoft.OpenApi/Services/OpenApiServersComparer.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public override void Compare(
3838
OpenApiDifferenceOperation = OpenApiDifferenceOperation.Update,
3939
SourceValue = sourceServers,
4040
TargetValue = targetServers,
41-
OpenApiComparedElementType = typeof(IList<OpenApiParameter>),
41+
OpenApiComparedElementType = typeof(IList<OpenApiServer>),
4242
Pointer = comparisonContext.PathString
4343
});
4444

0 commit comments

Comments
 (0)