Support additional blending equations#37
Open
eggera wants to merge 3 commits into
Open
Conversation
eggera
force-pushed
the
support-additional-blending-modes
branch
from
310a02d to
cfc0eb8
Compare
eggera
force-pushed
the
support-additional-blending-modes
branch
from
cfc0eb8 to
ec3504b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @nswamy14 and supporters,
I now created this pull request to add support for different blending equations. I created an issue for that topic before: #36
It is a simple change in config which would allow users to choose their own blending equation as it fits to their use cases.
In my case this would be a total game changer, since for our product we would need a different blending equation for the heatmap to actually make sense.
There are not many heatmap implementations out there that provide a smooth interpolation of values and are maintained timely. Therefore it would be very valuable if this config could be set for this library.
I made the necessary changes in the code and generated the dist folder as expected, and also added some lines to the README to have a reference for how to use this config.
Basically a new config
blendEquationhas been added that can be set to the following values:"ADD","MIN","MAX","SUBTRACT","REVERSE_SUBTRACT"These will be mapped to the corresponding function for the blendEquation. In case the config is not set, it will default to
"ADD", which has been the known behavior until now.In addition the config can be set via the method
setBlendEquation, similar to other configs.It would be great if this PR would be considered for merge. Of course I could still do any changes necessary to adhere to coding guidelines or other rules, or make further changes so that it fits to the library.