[Snyk] Security upgrade protobuf from 4.24.4 to 6.33.5 #3
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PROTOBUF-15090738
Summary of ChangesHello @nssuwan186-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability in the protobuf package. However, the suggested version 6.33.5 for the Python protobuf package is invalid and does not exist on PyPI, which would break the build. Additionally, other dependencies in this project constrain protobuf to versions below 5.0. I have left a comment with a suggested fix to pin protobuf to a recent, valid version (4.25.3) that should resolve the vulnerability while respecting existing dependency constraints.
| google-api-python-client==2.134.0 | ||
| google-auth==2.30.0 | ||
| google-auth-httplib2==0.2.0 | ||
| protobuf>=6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
The suggested version 6.33.5 for the protobuf Python package is not a valid version and does not exist on PyPI. This will cause dependency installation to fail.
Furthermore, a transitive dependency, google-api-core (from google-api-python-client), requires protobuf<5.0.0dev, which would conflict with this version even if it existed.
To fix the security vulnerability while maintaining compatibility, you should pin protobuf to a recent version in the 4.x series, such as 4.25.3. This is consistent with how other dependencies are pinned in this file using ==.
protobuf==4.25.3 # not directly required, pinned to avoid a vulnerability
2 participants
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
samples/compute/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.