fix(json): improve JSON parse error reporting

zkat · zkat · commit 1c810dfedd21 · 2017-05-23T17:21:49.000-07:00
It's not uncommon for services to send back bad JSON on errors, specially things like proxies, or if you get the wrong URI. This way, we can actually find out what the bad JSON was.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,6 +69,7 @@
   },
   "dependencies": {
     "encoding": "^0.1.11",
+    "json-parse-helpfulerror": "^1.0.3",
     "safe-buffer": "^5.0.1"
   }
 }
diff --git a/src/body.js b/src/body.js
@@ -11,6 +11,7 @@ const Buffer = require('safe-buffer').Buffer
 const Blob = require('./blob.js')
 const BUFFER = Blob.BUFFER
 const convert = require('encoding').convert
+const parseJson = require('json-parse-helpfulerror').parse
 const FetchError = require('./fetch-error.js')
 const Stream = require('stream')
 
@@ -92,7 +93,7 @@ Body.prototype = {
    * @return  Promise
    */
   json () {
-    return consumeBody.call(this).then(buffer => JSON.parse(buffer.toString()))
+    return consumeBody.call(this).then(buffer => parseJson(buffer.toString()))
   },
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@`
`69`	`69`	`},`
`70`	`70`	`"dependencies": {`
`71`	`71`	`"encoding": "^0.1.11",`
	`72`	`+ "json-parse-helpfulerror": "^1.0.3",`
`72`	`73`	`"safe-buffer": "^5.0.1"`
`73`	`74`	`}`
`74`	`75`	`}`