Allow sending queries from INpgsqlDatabaseInfoFactory.Load - #6634
Open
vonzshik wants to merge 1 commit into
Open
Allow sending queries from INpgsqlDatabaseInfoFactory.Load#6634vonzshik wants to merge 1 commit into
vonzshik wants to merge 1 commit into
Conversation
gfoidl
reviewed
Aug 19, 2026
| /// database isn't of the correct type and isn't handled by this factory. | ||
| /// </returns> | ||
| Task<NpgsqlDatabaseInfo?> Load(NpgsqlConnector conn, NpgsqlTimeout timeout, bool async); | ||
| Task<NpgsqlDatabaseInfo?> Load(NpgsqlConnector conn, NpgsqlTimeout timeout, bool async, CancellationToken cancellationToken = default); |
Contributor
There was a problem hiding this comment.
This is a breaking change.
Do the strict rules also apply to members being experimental?
Contributor
Author
There was a problem hiding this comment.
This is indeed a breaking change, although given that this API was flawed for years and no one complained, I guess it's not really used by anyone other than us. But let's see what others also think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6633