Rewrite NpgsqlConnectionStringBuilderSourceGenerator as incremental#6186
Merged
roji merged 1 commit intonpgsql:mainfrom Oct 2, 2025
Merged
Rewrite NpgsqlConnectionStringBuilderSourceGenerator as incremental#6186roji merged 1 commit intonpgsql:mainfrom
roji merged 1 commit intonpgsql:mainfrom
Conversation
Member
|
@manandre do you mind rebasing this on latest main and checking out the failures? Re incremental vs. traditional (deprecated) source generators, thanks for doing the work here... In this particular case there's very little chance the shift to incremental will help (as this is a very low-volume internally-used generator only), so we can also skip that if it causes trouble. |
159dfc0 to
8f63de1
Compare
Collaborator
Author
|
Rebased |
8f63de1 to
6b7b8de
Compare
Collaborator
Author
|
I have reverted:
|
6b7b8de to
59d5446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And bump Microsoft.CodeAnalysis.Analyzers and Microsoft.CodeAnalysis.CSharp.
Enforces migration from (deprecated) source generators to incremental generators