Skip to content

Rewrite NpgsqlConnectionStringBuilderSourceGenerator as incremental#6186

Merged
roji merged 1 commit intonpgsql:mainfrom
manandre:codeanalysis-4.14
Oct 2, 2025
Merged

Rewrite NpgsqlConnectionStringBuilderSourceGenerator as incremental#6186
roji merged 1 commit intonpgsql:mainfrom
manandre:codeanalysis-4.14

Conversation

@manandre
Copy link
Copy Markdown
Collaborator

@manandre manandre commented Sep 7, 2025

And bump Microsoft.CodeAnalysis.Analyzers and Microsoft.CodeAnalysis.CSharp.

Enforces migration from (deprecated) source generators to incremental generators

@roji
Copy link
Copy Markdown
Member

roji commented Sep 10, 2025

@manandre do you mind rebasing this on latest main and checking out the failures?

Re incremental vs. traditional (deprecated) source generators, thanks for doing the work here... In this particular case there's very little chance the shift to incremental will help (as this is a very low-volume internally-used generator only), so we can also skip that if it causes trouble.

@manandre
Copy link
Copy Markdown
Collaborator Author

Rebased

@manandre
Copy link
Copy Markdown
Collaborator Author

I have reverted:

  • Microsoft.CodeAnalysis.CSharp to version 4.13.0 as there is a conflict with the roslyn version embedded in the .NET SDK
  • Microsoft.CodeAnalysis.Analyzers to version 3.11.0 as version 4.14.0 has been removed

@manandre manandre changed the title Move CodeAnalysis to version 4.14 Bump Microsoft.CodeAnalysis.Analyzers and Microsoft.CodeAnalysis.CSharp Sep 11, 2025
Copy link
Copy Markdown
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @manandre, LGTM!

@roji roji merged commit 444c77a into npgsql:main Oct 2, 2025
16 checks passed
@roji roji changed the title Bump Microsoft.CodeAnalysis.Analyzers and Microsoft.CodeAnalysis.CSharp Rewrite NpgsqlConnectionStringBuilderSourceGenerator as incremental Oct 2, 2025
@manandre manandre deleted the codeanalysis-4.14 branch October 2, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants