Improve type mapping collection code#5920
Merged
NinoFloris merged 4 commits intomainfrom Nov 16, 2024
Merged
Conversation
NinoFloris
force-pushed
the
improve-type-mapping-collection
branch
from
a392326 to
ddf3035
Compare
vonzshik
approved these changes
Nov 14, 2024
Contributor
vonzshik
left a comment
vonzshik
left a comment
There was a problem hiding this comment.
Looks good enough, just a few comments
Also make includeDataTypeName required, important to consciously consider passing the right value for correctness.
Also add some commentary on its use
NinoFloris
force-pushed
the
improve-type-mapping-collection
branch
from
ddf3035 to
1a7485e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overloads for the most commonly used CreateInfo calls. It should also help binary size due to removing optional args being passed from the many call sites (EDIT: tiny reduction of %o1). Introduces a tiny breaking change in an area no public plugins use (resolvertypeinfo) by requiring includeDataTypeName to be passed.
This particular change helps to prepare for #5472 (which was very messy due to the current optional params). I might end up making some options type or configure lambda to do the PgTypeInfo configuration, instead of adding more overloads with more optional params.
This PR also contains some clarification comments and a refactor of TypeInfoFactory resolvedDataTypeName => requiresDataTypeName.