Skip to content

Fix another sequential buffered seek exit state issue#5486

Merged
NinoFloris merged 2 commits intomainfrom
fix-another-sequential-seek-exit-state
Jan 24, 2024
Merged

Fix another sequential buffered seek exit state issue#5486
NinoFloris merged 2 commits intomainfrom
fix-another-sequential-seek-exit-state

Conversation

@NinoFloris
Copy link
Copy Markdown
Member

@NinoFloris NinoFloris commented Dec 7, 2023

Might finally put #5430 to bed...

We'll have to decide to take this one or take the straight forward algorithm (but larger change overall) in #5476 for 8.0.2.

@NinoFloris NinoFloris mentioned this pull request Dec 7, 2023
Closed
@NinoFloris
Fix another sequential buffered seek exit state issue
a7c3cd0
@NinoFloris
Fix reread init size
db362fa 
This worked entirely by accident before due to us not resetting FieldSize after Commit
@NinoFloris NinoFloris force-pushed the fix-another-sequential-seek-exit-state branch from 3e08f38 to db362fa Compare December 7, 2023 15:59
vonzshik
vonzshik approved these changes Dec 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's go with the simplest solution we have for backporting. If we ever encounter another issue which should have been fixed with #5476, then we'll think about backporting that pr.

@yunfandev
Copy link
Copy Markdown

yunfandev commented Jan 18, 2024 •
edited
Loading

@NinoFloris @roji

Hi, I hope this message finds you well. I've been closely following this pull request and appreciate the work that has gone into it. Understanding that everyone is quite busy, I was wondering if there might be any updates on the timeline for a review or merge. Thank you for your dedication to maintaining this project! And whether the issue addressed in this pull request will be fixed in Npgsql version 8.0.2?

@NinoFloris NinoFloris merged commit dffa843 into main Jan 24, 2024
@NinoFloris NinoFloris deleted the fix-another-sequential-seek-exit-state branch January 24, 2024 21:46
NinoFloris added a commit that referenced this pull request Jan 31, 2024
@NinoFloris
Fix another sequential buffered seek exit state issue (#5486)
85ed424 
Fixes #5430

(cherry picked from commit dffa843)

# Conflicts:
#	src/Npgsql/NpgsqlDataReader.cs
@NinoFloris
Copy link
Copy Markdown
Member Author

NinoFloris commented Jan 31, 2024

Backported to 8.0.2 via 85ed424

This was referenced Oct 29, 2025
Closed
Closed
This was referenced Nov 5, 2025
Closed
Open
This was referenced Nov 17, 2025
Merged
Closed
This was referenced Dec 1, 2025
Closed
Closed
This was referenced Dec 8, 2025
Closed
Closed
This was referenced Dec 17, 2025
Closed
Open
Open
This was referenced Jan 5, 2026
Merged
Merged
@dependabot dependabot bot mentioned this pull request Feb 1, 2026
Open
@dependabot dependabot bot mentioned this pull request Feb 26, 2026
Closed
@dependabot dependabot bot mentioned this pull request Apr 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vonzshik vonzshik vonzshik approved these changes

@roji roji Awaiting requested review from roji roji is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NinoFloris @yunfandev @vonzshik