Merged
Conversation
NinoFloris
force-pushed
the
fix-reading-assignablefrom-mappings
branch
from
a19e003 to
a393f4a
Compare
NinoFloris
force-pushed
the
fix-reading-assignablefrom-mappings
branch
from
9bceeaf to
192bab0
Compare
roji
approved these changes
Nov 3, 2025
| static (options, mapping, _) => new PgTypeInfo(options, new IPAddressConverter(), | ||
| new DataTypeName(mapping.DataTypeName), unboxedType: mapping.Type == typeof(IPAddress) ? null : mapping.Type), | ||
| static (options, mapping, _) => new PgTypeInfo(options, new IPAddressConverter(), new DataTypeName(mapping.DataTypeName), | ||
| unboxedType: mapping.Type != typeof(IPAddress) ? mapping.Type : null), |
Member
There was a problem hiding this comment.
Super minor nit: FWIW I prefer the the previous ternary to avoid double negation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See test for what used to resolve succesfully.
Originally
StreamByteaConverterwould throw NotSupported during reading. Had it implemented the read methods though (i.e. viareader.GetStream()) as is done in #5480 we would start to throw at the GetFieldValueCore level trying to cast the return value from ReadAsObject (runtime typeColumnStream) to the requestedNetworkStream.In the case of IPAddressConverter we would throw inside the casting converter on read, trying to cast an IPAddress instance to whatever derived type was requested.
Better to head these cases off just after finding an info via a new read side analog of SupportsWriting.