Skip to content

Conversation

@vonzshik
Copy link
Contributor

Closes #4966

@vonzshik vonzshik requested a review from roji as a code owner March 24, 2023 16:02
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

@vonzshik
Copy link
Contributor Author

Looks better!

Yeah, but funny story, we still have to support SASL authentication. It's just there are different bindings, and one of them requires SSL, while another doesn't.

@vonzshik
Copy link
Contributor Author

OK. I had to change a few more things, but now instead of shaving off 12kb we save about 210kb. This is done by removing a reference to X509Certificate2 via _rootCertificateCallback.

@vonzshik vonzshik requested a review from roji March 25, 2023 19:25
@vonzshik vonzshik enabled auto-merge (squash) March 25, 2023 21:06
@vonzshik vonzshik merged commit 43a2e98 into main Mar 25, 2023
@vonzshik vonzshik deleted the 4966-remove-certificate-reference branch March 25, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow disabling encryption to reduce binary size

2 participants