Reduce AOT size of ArrayHandler #4926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
commented
Feb 11, 2023
| static Exception CantWriteTypeException(Type type) | ||
| => new InvalidCastException($"Can't write type {type} as an array of {typeof(TElement)}"); | ||
| static InvalidCastException CantWriteTypeException(Type type) | ||
| => new($"Can't write type {type} as an array of {typeof(TElement)}"); |
Contributor
Author
There was a problem hiding this comment.
Surprisingly, moving CantWriteTypeException together with CantWriteTypeException to base class results in 16kb size regression (no idea why, perhaps because we pass the type?).
Contributor
Author
There was a problem hiding this comment.
Yeah, still the same.
vonzshik
force-pushed
the
4799-reduce-array-handler-aot-size
branch
from
f060566 to
919ea79
Compare
roji
approved these changes
Feb 27, 2023
| static Exception CantWriteTypeException(Type type) | ||
| => new InvalidCastException($"Can't write type {type} as an array of {typeof(TElement)}"); | ||
| static InvalidCastException CantWriteTypeException(Type type) | ||
| => new($"Can't write type {type} as an array of {typeof(TElement)}"); |
vonzshik
force-pushed
the
4799-reduce-array-handler-aot-size
branch
from
373920c to
5ada2f7
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4799