Skip to content

Conversation

@vonzshik
Copy link
Contributor

@vonzshik vonzshik commented Jan 20, 2023

Contributes to #4799

Now, there are 3 issues with ILinker:

  1. For some reason it doesn't get rid of NpgsqlDataReader.GetValues (even though it's not called) (upd: it's called by DbEnumerator, which we return from GetEnumerator, Linker doesn't trim IEnumerable interface in console app even if it's not used dotnet/linker#3189)
  2. NpgsqlDataReader.GetFieldValue is never called with T as object, yet ReadAsObject (which is only called with T as object) is never removed
  3. Sometimes (RecordHandler.Read) ILinked doesn't realise that RuntimeFeature.IsDynamicCodeSupported makes sure nothing below is called with AOT, yet it's still preserved.

Probably a good idea to also check with .NET 8 (I've compiled on windows with .NET 7.0.1).
Same thing with .NET 8.

cc @roji @MichalStrehovsky

@vonzshik vonzshik force-pushed the 4799-native-aot-remove-array-handler branch from 0becf0c to 3146e21 Compare January 23, 2023 10:26
@vonzshik vonzshik force-pushed the 4799-native-aot-remove-array-handler branch from 3146e21 to f04a13c Compare February 28, 2023 07:23
@NinoFloris NinoFloris mentioned this pull request Aug 15, 2023
8 tasks
@NinoFloris NinoFloris added this to the 8.0.0 milestone Sep 25, 2023
@Brar Brar removed this from the 8.0.0 milestone Nov 21, 2023
@NinoFloris NinoFloris deleted the 4799-native-aot-remove-array-handler branch March 27, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants