Use NpgsqlDataSource in all tests #4882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Jan 16, 2023
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing all the legwork!
See some comments below, nothing critical that can't be fixed later in a separate PR.
One slight concern is that we now have much less actual test coverage for the non-datasource mode, so things may end up regressing without us knowing. Something to keep in mind.
roji
reviewed
Jan 16, 2023
roji
reviewed
Jan 16, 2023
roji
force-pushed
the
4572-data-sources-all-the-way
branch
from
b39319a to
dd67aa5
Compare
Member
|
@vonzshik pushed 2 commits to this PR - take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4572