Hey @roji,

Just wanted to check in with you about the refactoring in NpgsqlDataSourceBuilder. I noticed that most of the code is in NpgsqlSlimDataSourceBuilder now. Do you think it would make sense for me to move the non-generic enum methods there? Or are there still more changes planned for this module?

Sorry if these are silly questions. I'm pretty new to open-source contributions and just want to make sure I'm doing things correctly. I'm excited to merge my changes with the main branch and tackle the next issue!

Thanks so much for your help.

@BogdanYarotsky your questions aren't silly at all, they make total sense. And sorry we haven't already reviewed and merged your PR, there's just a lot going on.

We've refactored NpgsqlDataSourceBuilder to be mostly a wrapped around NpgsqlSlimDataSourceBuilder, which automatically opts into various features that people don't necessarily want when working in NativeAOT mode (either because they aren't compatible with NativeAOT, or because they increase the size and should be opt-in). So you should follow the same pattern and do the implementation in NpgsqlSlimDataSourceBuilder, with a wrapping in NpgsqlDataSourceBuilder. Basically follow what you see for the generic version.

@roji thank you for the heads-up! I'll keep this in mind and will update the PR this week.

Hi @roji,
Can you please take a look at the PR? I think it is ready for a merge. I have noticed that NpgsqlDataSourceBuilder EnumUnmap methods had no unit tests so I added some. I used existing GlobalTypeMapper tests as an example. Please let me know if more changes are needed.

@BogdanYarotsky I've fixed all the conflicts and updated the branch to be rebased on main. There were quite some changes here after #5123. We should be able to merge it some time soon!

@NinoFloris that's great news! Thank you for the rebase and the info 🙂 Just ping me if an action is needed from my side.