Support multiple hosts with NpgsqlDataSource #4531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
DataSource/MultiHost
branch
from
e88d3dd to
b82f2c6
Compare
roji
force-pushed
the
DataSource/MultiHost
branch
from
b82f2c6 to
463e9e0
Compare
NinoFloris
approved these changes
Jul 4, 2022
Member
NinoFloris
left a comment
NinoFloris
left a comment
There was a problem hiding this comment.
Functionally it looks great, I'll leave the architectural concerns, which I share to some extent, to @vonzshik
| /// <summary> | ||
| /// Builds and returns a <see cref="NpgsqlMultiHostDataSource" /> which is ready for use for load-balancing and failover scenarios. | ||
| /// </summary> | ||
| public NpgsqlMultiHostDataSource BuildMultiHost() |
Member
There was a problem hiding this comment.
Could/should? this be an extension method?
Member
Author
There was a problem hiding this comment.
Any particular reason? It's all built-in support, I don't anticipate us introducing many other types of data source types etc.
Member
There was a problem hiding this comment.
Yeah, that's why it's a double question.
Member
Author
There was a problem hiding this comment.
I think it's OK... And we usually don't care about binary compat that much that we couldn't change it to an extension in a major version if we really wanted to...
roji
force-pushed
the
DataSource/MultiHost
branch
from
463e9e0 to
f526272
Compare
roji
force-pushed
the
DataSource/MultiHost
branch
from
f526272 to
9daf2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4321