Password management and rotation in NpgsqlDataSource #4529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
DataSource/Password
branch
from
a6ac248 to
d11579d
Compare
vonzshik
approved these changes
Jul 3, 2022
…uite No actual changes, just move code around
Co-authored-by: Nikita Kazmin <vonzshik@gmail.com>
NinoFloris
reviewed
Jul 4, 2022
| { | ||
| // A periodic password provider is configured, but the first refresh hasn't completed yet (race condition). | ||
| // Wait until it completes. | ||
| if (_password is null && _passwordRefreshTask is not null) |
Member
There was a problem hiding this comment.
Check should be redundant now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4497