Allow setting serialized ConvertedValue for JSON objects #4248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when adding a json parameter in queries, the serialized json document in bytes gets copied multiple times. One time in
JsonHandler.SerializeJsonDocumentwhen writing the byte array, which is then copied once the function returns. If this function gets called frequently with large documents, blocks will become allocated on LOH which is far from ideal in high performance critical application.This change allows me to use strategies such as buffer pooling when building the JSON object, for example:
The function
SerializeToBytescan then use for example a RecyclableMemoryStream to re-use the memory being used for sending the documents.Related to the discussion here: #1727