Skip to content

Fix range infinite recursion issue for Native AOT #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roji merged 1 commit into from
Nov 4, 2021
Merged

Fix range infinite recursion issue for Native AOT #4095

roji merged 1 commit into from
Nov 4, 2021

Conversation

@roji
Copy link
Member

@roji roji commented Nov 4, 2021

And add basic Native AOT check to CI

Fixes #4057

@roji roji requested a review from vonzshik as a code owner November 4, 2021 10:18
@roji roji force-pushed the AOT branch 4 times, most recently from 6035660 to 7917c64 Compare November 4, 2021 10:47
@roji roji enabled auto-merge (squash) November 4, 2021 10:50
@roji roji merged commit fa726b6 into npgsql:main Nov 4, 2021
@roji roji deleted the AOT branch November 4, 2021 10:56
@roji
Copy link
Member Author

roji commented Nov 4, 2021

Before this PR, trying to publish with Native AOT would generate a lot of these:

ILC : AOT analysis warning IL1005: Npgsql.Internal.TypeHandlers.MultirangeHandler`1<NpgsqlRange`1<NpgsqlRange`1<NpgsqlRange`1<NpgsqlRange`1<__Canon>>>>>.ValidateAndGetLengthMultirange<NpgsqlRange`1<NpgsqlRange`1<NpgsqlRange`1<NpgsqlRange`1<__Canon>>>>>(IList`1<NpgsqlRange`1<NpgsqlR
ange`1<NpgsqlRange`1<NpgsqlRange`1<NpgsqlRange`1<__Canon>>>>>>,NpgsqlLengthCache&,NpgsqlParameter): Method will always throw because: Failed to load type 'Npgsql.Internal.TypeHandling.NpgsqlTypeHandler' from assembly 'Npgsql, Version=6.0.0.0, Culture=neutral, PublicKeyToken=5d8b90d
52f46fda7' [/home/roji/projects/test/Test.csproj]

After this PR, those are gone. /cc @MichalStrehovsky

We'll be adding a basic CI check for Native AOT after 6.0 ships, see #4096.

@roji roji mentioned this pull request Nov 4, 2021
Merged
@roji roji mentioned this pull request Jan 19, 2023
Merged
@MichalStrehovsky MichalStrehovsky mentioned this pull request Sep 20, 2023
Closed
@MichalStrehovsky MichalStrehovsky mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vonzshik vonzshik vonzshik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generic infinite recursion in NativeAOT (again)

2 participants

@roji @vonzshik