-
Notifications
You must be signed in to change notification settings - Fork 877
Bind type handlers lazily #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
reviewed
Jun 10, 2021
Better handling of initialized/non-initialized
vonzshik
requested changes
Jun 11, 2021
vonzshik
approved these changes
Jun 11, 2021
Contributor
vonzshik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big PR which makes our type handler binding lazy; it both helps perf in various ways (no need to set up all those exotic type handlers for everyone, and take up memory), and gets some AOT-unfriendly code out of the way unless it's really used (e.g. range binding).
This also changes how mappings are tracked across the global and connector type mappers. The global type mapper now maintains immutable mapping data structures which are simply referenced directly by the connector type mappers. If users do any mapping changes on a connector (rare), we copy-on-write the structures to the connector type mapper.
Since this is a big change, I expect there to be a bug-tail in 6.0.0 for some more exotic mapping changes. Careful reviewing would be greatly appreciated! /cc @vonzshik @NinoFloris @Brar
Closes #3816
Closes #2263
Part of #3300