Remove reflection from NpgsqlConnectionStringBuilder #3819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
MoreReflectionBegone
branch
from
b44e954 to
9af93ea
Compare
roji
force-pushed
the
MoreReflectionBegone
branch
from
9af93ea to
a75f20e
Compare
NinoFloris
approved these changes
Jun 7, 2021
Member
NinoFloris
left a comment
NinoFloris
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
Looks good, considering the janky shape of the type :p (why is everything in ado.net defined as being dynamically and statically accessible...)
Testing under reflection free mode we can now successfully create and open a connection, then it breaks at a few more places in the type mapper init. By hacking around those everything starts working!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3814