Recover the buffer position when type handler throws, for sequential read #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emill
force-pushed
the
recover-buffer-pos
branch
from
54ca855 to
fc85fe6
Compare
Emill
commented
Apr 11, 2021
Comment on lines
1520
to
1527
| { | ||
| if (Connector.State != ConnectorState.Broken) | ||
| { | ||
| var writtenBytes = Buffer.ReadPosition - position; | ||
| var remainingBytes = ColumnLen - writtenBytes; | ||
| var readBytes = Buffer.ReadPosition - position; | ||
| var remainingBytes = ColumnLen - readBytes; | ||
| if (remainingBytes > 0) | ||
| Buffer.Skip(remainingBytes, false).GetAwaiter().GetResult(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Do we really need to catch and handle exception thrown inside type handlers for the non-sequential case, and make sure skip to end? Can't we leave it at any ReadPosition? When the next column or row is read, a new seek to column (or seek to row end if we move to the next row) is done anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3648.