Clear all pools also deletes pools#3395
Merged
vonzshik merged 5 commits intonpgsql:mainfrom Dec 11, 2020
Merged
Conversation
roji
reviewed
Dec 10, 2020
roji
reviewed
Dec 11, 2020
roji
approved these changes
Dec 11, 2020
Contributor
Author
|
Backported to 5.0.1 via 1b2cfff |
Member
|
Reverting this and publish 5.0.1.1. Instances of NpgsqlConnection maintain a reference to their pool even when their closed (to speed up re-opens), so if ClearAllPools is called we end up having two pools for the same connection string. We'll revisit this for 5.0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3387