Update patch versions#732
Conversation
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Thanks for doing this - looks good, but take a look at my comments on the version management and general hotfix vs. dev practices.
One more important point, is that I think this release should be called 2.1.4 rather than 2.1.3, as it depends on EF Core 2.1.4. Even if this would leave a "hole" in our versioning, I think there's value in aligning versions with EF Core as much as possible. Let me know what you think.
That sounds great. I just created a branch for Scratch that, just realized I can switch the base branch...much easier. |
austindrenski
force-pushed
the
hotfix-2.1.3-update-patch-versions
branch
from
e56789b to
ce31a2b
Compare
|
Updated, but note that this now depends on the availability of version So checks are expected to fail until those are released. |
|
|
|
Test failures in |
|
I'm trying to update this for I'm starting to debug these now, but there's no direct comparison with Does anyone have a sense of what's happening here? /cc @roji @YohDeadfall? |
|
It looks like this line leads to the seeding errors: Here's the spatial data seeded by EF Core. It doesn't look like they seed any My first thought was that we might be passing back a malformed public static readonly IGeometryCollection Empty =
Geometry.DefaultFactory.CreateGeometryCollection((IGeometry[]) null);But that still triggers the My current concern is that there may be another bug in the Looking further into it, I think the problem lies in this code: private static Ordinates CheckOrdinates(IGeometry geometry)
{
if (geometry is IPoint)
return CheckOrdinates(((IPoint)geometry).CoordinateSequence);
if (geometry is ILineString)
return CheckOrdinates(((ILineString)geometry).CoordinateSequence);
if (geometry is IPolygon)
return CheckOrdinates((((IPolygon)geometry).ExteriorRing).CoordinateSequence);
if (geometry is IGeometryCollection)
return CheckOrdinates(geometry.GetGeometryN(0));
Assert.ShouldNeverReachHere();
return Ordinates.None;
}With a patch looking something like this: private static Ordinates CheckOrdinates(IGeometry geometry)
{
if (geometry is IPoint)
return CheckOrdinates(((IPoint)geometry).CoordinateSequence);
if (geometry is ILineString)
return CheckOrdinates(((ILineString)geometry).CoordinateSequence);
if (geometry is IPolygon)
return CheckOrdinates((((IPolygon)geometry).ExteriorRing).CoordinateSequence);
if (geometry is IGeometryCollection collection)
{
return collection.Count == 0
? Ordinates.None
: CheckOrdinates(collection.GetGeometryN(0));
}
Assert.ShouldNeverReachHere();
return Ordinates.None;
}/cc @roji @airbreather |
|
Just to keep things moving, I've opened the following PRs with patches for |
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
OK, thanks.
Of course we have to remember to put these tests back for 2.1.5. Or we can do that right away after release on hotfix/2.1.5 and depend on the floating version of Npgsql.NetTopologySuite, which is probably best.
3 participants
Updates
hotfix/2.1.4to manage package versions withDirectory.Build.propsas ondev.Bumps dependency patch versions:
Microsoft.EntityFrameworkCore*2.1.32.1.4Microsoft.NET.Test.Sdk15.7.215.9.0Npgsql4.0.34.0.4Npgsql.*1.0.*4.0.4SourceLink.Create.CommandLine2.8.12.8.3xunit*2.3.12.4.1