Repository navigation
Fix Bash function list broken by quoted here-document delimiter - #18545
Open
haraldrohan wants to merge 2 commits into
Open
haraldrohan wants to merge 2 commits into
haraldrohan wants to merge 2 commits into
Conversation
The here-document part of the Bash commentExpr only accepted an unquoted delimiter (<<EOF). With a quoted one (<<'EOF', <<"EOF", <<\EOF), the here-document wasn't recognized, so a single quote inside it started a string literal that swallowed the following functions. Allow an optional quote or backslash before the delimiter, and add a unit test covering the quoted forms. Fix notepad-plus-plus#13849 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chcg
added
the
language-support
Contributor
|
@haraldrohan |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks! I agree the wording was confusing and reworded the test file, hope that explains it better now. The bodies now also contain a lone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13849.
bash.xmlonly recognized here-documents with an unquoted delimiter (<<EOF). With a quoted one (<<'EOF',<<"EOF",<<\EOF), a single quote inside the here-document started a string literal that swallowed the following functions.Fix
Allow an optional
",'or\before the delimiter in both here-document forms (<<and<<-). The closing quote is already consumed by the existing[^\r\n]*.Test plan
bash/quoted_heredocwith the example from the issue plus<<"END",<<\ENDand<<-'END': fails before (1 of 5 functions listed), passes after, with LF and CRLF.🤖 Generated with Claude Code