Repository navigation
Conversation
bcaf407 to
35d0245
Compare
35d0245 to
1a0635a
Compare
That's not quite how most people read that instruction. Specifically, it says:
That means that before a PR is merged, the underlying issue must be accepted by an administrator: they can do that explicitly, either before or after a PR is submitted, or implicitly, by the primary developer choosing to merge the PR. Since the primary developer reviews all PRs, and decides whether or not to merge them, his review and merging is tacit "approval", even if he doesn't bother changing the label on the Issue. As far as I've seen, he doesn't generally review a PR that is marked as draft (I don't even know if he reads draft PR; he's very busy), and isn't likely to mark the original issue as As such: once you believe your PR is ready, mark it "ready for review". Then, as the developer has time, he will review it, and decide whether or not to merge it. |
|
Thank you, @pryrt, for clarifying how the Accepted-label requirement is applied and for pointing out that draft PRs may not be reviewed. I've marked the PR ready for review. |
Comments like the following show that there is some confusion as to the requirements for Pull Requests: - notepad-plus-plus#18278 (comment) - notepad-plus-plus#17565 (comment) In general: - People have historically thought they needed to wait for the Issue to be `Accepted` before submitting a PR - People get confused as to whether or not they need an Issue to attach their PR to - People have historically asked to be assigned to open Issues, and never get assigned, so they never put in a PR (I know I have seen that in some of Issues I've read, but cannot immediately find an example) I have tried to reword things so that those are all more clear, and match the current practices (don't need to wait for `Accepted`; almost always need to attach to Issue or comment; don't need to ask to be assigned to Issue)
Comments like the following show that there is some confusion as to the requirements for Pull Requests: - #18278 (comment) - #17565 (comment) In general: - People have historically thought they needed to wait for the Issue to be `Accepted` before submitting a PR - People get confused as to whether or not they need an Issue to attach their PR to - People have historically asked to be assigned to open Issues, and never get assigned, so they never put in a PR (I know I have seen that in some of Issues I've read, but cannot immediately find an example) I have tried to reword things so that those are all more clear, and match the current practices (don't need to wait for `Accepted`; almost always need to attach to Issue or comment; don't need to ask to be assigned to Issue) Close #18469
What and why
Word wrap was represented only by the global Scintilla view preference, and the existing command applied that value indiscriminately to both editor views. As a result, switching tabs could not preserve a document-specific choice, and opening a large file could disable wrapping globally for unrelated documents.
This change adds a persistent three-state word-wrap mode to each document buffer:
The existing View menu and toolbar command remain global. Global changes update only visible documents using the global setting, while their checked state continues to represent the global preference.
User impact
wrapMode="global|off|on"in session files.Compatibility
Older session files without
wrapMode, and session files containing an unrecognized value, default to Use Global Setting. Untranslated languages retain the built-in English labels. No plugin API changes are introduced.Validation
python PowerEditor\Test\xmlValidator\validator_xml.pygit diff --checkFixes #5232