Remove deprecated rc module #3134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Shouldn't we announce a deprecation first instead of just having a module vanish without warning or explanation? |
Member
Author
|
Well, the documentation already described it as "superseded", but I'm happy to wait for the |
It has long been superseded by the rfswitch module
Member
|
Missing: removal of |
Member
Author
|
Hm... This and #3123 passed CI even with the bad |
Member
|
Yes, but the docs build on RTD failed and that info isn't fed back to GitHub. Not sure if/how that could be achieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has long been superseded by the rfswitch module.
Hold as PR until after next master cut.