Fixes for ws2812 and ws2812_effects
#2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHHartmann
commented
Nov 2, 2019
4 tasks
Member
vsky279
pushed a commit
to vsky279/nodemcu-firmware
that referenced
this pull request
Dec 27, 2019
* clean effects library * Fix several issues in ws2812 and effects * Implement working way of calling shift from callback
marcelstoer
pushed a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2946 #2921 and more.
devbranch rather than formaster.docs/*.Cleanup code and fix issues in
ws2812andws2812_effectsBesides the afore mentioned ones I fixed a false bounds check in
ws2812_effects.set_brightnessandws2812_effects.set_speedAlso add some automated tests to show the differences between current and this implementation.
You will need to precompile at least the mispec.lua file to not run out of memory.
If you don't like them I will remove them from the PR.