Conversation
|
This is a lot of progress! Thanks! I'll have to confirm on my side whether it's working before merging. It may take some time, but I'll get to it. |
|
Sure thing :) Only thing missing here are unit tests which I'm not too familiar with. |
|
Wow, thank you for the work @1Conan! I'm compiling it but so far it seems going smoothly! |
|
Can confirm, it's working well so far, even with native modules. I wonder if it's trivial to update to the latest Node.js v16.14.0? |
|
I think it should be. iirc there shouldn't be any major changes. |
|
|
|
@1Conan sent me the compiled .framework. I've converted it to an xcframework with |
Great! Thank you. That will do it for now but I think changes probably still need to be made before merging. |
I forgot that it's gitignore-d by default I'll commit it later on. |
Hey @1Conan. It would be really appreciated if you can include internationalization support as well. Drop me an email at ken.chung@thebaselab.com if you'd like bounty. |
Just to note, I have added a CI build for this now. Though it's on 16.14.2 |
|
Hey, thanks for your PR, it provided some inspiration and guidance. However, I have now merged #9 which updated nodejs-mobile to 16.17.1 for both Android and iOS. Can we close this PR? |
There's a warning about missing symbols for libv8_base_without_compiler.a when building the dSYM file in the framework.
Checklist