Skip to content

iOS build#5

Closed
1Conan wants to merge 3 commits into
nodejs-mobile:upstream-node-v16.13.2from
1Conan:upstream-node-v16.13.2-ios
Closed

iOS build#5
1Conan wants to merge 3 commits into
nodejs-mobile:upstream-node-v16.13.2from
1Conan:upstream-node-v16.13.2-ios

Conversation

@1Conan

@1Conan 1Conan commented Feb 26, 2022

Copy link
Copy Markdown

There's a warning about missing symbols for libv8_base_without_compiler.a when building the dSYM file in the framework.

Checklist

@staltz

staltz commented Feb 26, 2022

Copy link
Copy Markdown
Member

This is a lot of progress! Thanks! I'll have to confirm on my side whether it's working before merging. It may take some time, but I'll get to it.

@KishanBagaria KishanBagaria mentioned this pull request Feb 26, 2022
6 tasks
@1Conan

1Conan commented Feb 26, 2022

Copy link
Copy Markdown
Author

Sure thing :)

Only thing missing here are unit tests which I'm not too familiar with.

@bummoblizard

Copy link
Copy Markdown

Wow, thank you for the work @1Conan! I'm compiling it but so far it seems going smoothly!

@KishanBagaria

Copy link
Copy Markdown

Can confirm, it's working well so far, even with native modules.

I wonder if it's trivial to update to the latest Node.js v16.14.0?

@1Conan

1Conan commented Feb 26, 2022

Copy link
Copy Markdown
Author

I think it should be. iirc there shouldn't be any major changes.

@bummoblizard

Copy link
Copy Markdown

NodeMobile.xcodeproj seems to be missing. How did you manage to build the framework? @KishanBagaria

@KishanBagaria

Copy link
Copy Markdown

@1Conan sent me the compiled .framework. I've converted it to an xcframework with xcodebuild -create-xcframework -framework NodeMobile.framework -output NodeMobile.xcframework and uploaded here: https://texts.com/dev/NodeMobile16.xcframework.zip (sha256: 19f8f624d68b8de5a570fe0f512c4d08b37d290e9a4bfb97f25ea135e446ad05)

@bummoblizard

Copy link
Copy Markdown

@1Conan sent me the compiled .framework. I've converted it to an xcframework with xcodebuild -create-xcframework -framework NodeMobile.framework -output NodeMobile.xcframework and uploaded here: https://texts.com/dev/NodeMobile16.xcframework.zip (sha256: 19f8f624d68b8de5a570fe0f512c4d08b37d290e9a4bfb97f25ea135e446ad05)

Great! Thank you. That will do it for now but I think changes probably still need to be made before merging.

@1Conan

1Conan commented Feb 26, 2022

Copy link
Copy Markdown
Author

NodeMobile.xcodeproj seems to be missing. How did you manage to build the framework? @KishanBagaria

I forgot that it's gitignore-d by default I'll commit it later on.

@bummoblizard

Copy link
Copy Markdown

NodeMobile.xcodeproj seems to be missing. How did you manage to build the framework? @KishanBagaria

I forgot that it's gitignore-d by default I'll commit it later on.

Hey @1Conan. It would be really appreciated if you can include internationalization support as well. Drop me an email at ken.chung@thebaselab.com if you'd like bounty.

@1Conan

1Conan commented Mar 24, 2022

Copy link
Copy Markdown
Author

NodeMobile.xcodeproj seems to be missing. How did you manage to build the framework? @KishanBagaria

I forgot that it's gitignore-d by default I'll commit it later on.

Hey @1Conan. It would be really appreciated if you can include internationalization support as well. Drop me an email at ken.chung@thebaselab.com if you'd like bounty.

Just to note, I have added a CI build for this now. Though it's on 16.14.2
small-icu is enabled
https://github.com/1Conan/nodejs-mobile/actions/runs/2025250174

@staltz

staltz commented Jan 24, 2023

Copy link
Copy Markdown
Member

Hey, thanks for your PR, it provided some inspiration and guidance. However, I have now merged #9 which updated nodejs-mobile to 16.17.1 for both Android and iOS. Can we close this PR?

@1Conan 1Conan closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants