Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 8, 2025

Refs: nodejs/build#4071
Refs: nodejs/node#58071

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings May 8, 2025 20:12
@aduh95 aduh95 requested a review from a team as a code owner May 8, 2025 20:12
@vercel
Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 8, 2025 8:13pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the download options in the Node.js release post template by removing the ARMv7 32-bit Binary for Node.js versions 24 and above.

  • Removed ARMv7 32-bit Binary download option when version is >= 24.0.0.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (862c078) to head (064c823).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7734      +/-   ##
==========================================
- Coverage   74.84%   74.82%   -0.03%     
==========================================
  Files          98       98              
  Lines        7888     7888              
  Branches      200      200              
==========================================
- Hits         5904     5902       -2     
- Misses       1983     1985       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@AugustinMauroy
Copy link
Member

I dont think you need this change now. But if you want you can fast track this pr

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@aduh95 aduh95 requested a review from a team May 9, 2025 11:26
@avivkeller avivkeller added the fast-track Fast Tracking PRs label May 9, 2025
@avivkeller
Copy link
Member

I'm fast tracking this given the unlikely change for anyone to object to this.

If you approve the fast track, merge when ready

@aduh95 aduh95 enabled auto-merge May 9, 2025 13:43
@richardlau richardlau added the github_actions:pull-request Trigger Pull Request Checks label May 9, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 9, 2025
@aduh95 aduh95 added this pull request to the merge queue May 9, 2025
Merged via the queue into nodejs:main with commit f4e5e2b May 9, 2025
27 checks passed
@aduh95 aduh95 deleted the fix-24-template branch May 9, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants