-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: remove link to ARMv7 from Node.js 24+ release post template #7734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the download options in the Node.js release post template by removing the ARMv7 32-bit Binary for Node.js versions 24 and above.
- Removed ARMv7 32-bit Binary download option when version is >= 24.0.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7734 +/- ##
==========================================
- Coverage 74.84% 74.82% -0.03%
==========================================
Files 98 98
Lines 7888 7888
Branches 200 200
==========================================
- Hits 5904 5902 -2
- Misses 1983 1985 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
|
I dont think you need this change now. But if you want you can fast track this pr |
|
Lighthouse Results
|
|
I'm fast tracking this given the unlikely change for anyone to object to this. If you approve the fast track, merge when ready |
Refs: nodejs/build#4071
Refs: nodejs/node#58071
Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.