Rename 'SunOS' download option to 'SmartOS' #1989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Jan 17, 2019
rvagg
approved these changes
Jan 17, 2019
ZYSzys
approved these changes
Jan 17, 2019
fhemberger
added a commit
that referenced
this pull request
Jan 18, 2019
Old builds tagged with `sunos` are still called "Solaris", all other references to "SunOS" have been renamed. See https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 Follow up PR to #1989
ghost
pushed a commit
that referenced
this pull request
Jan 20, 2019
Old builds tagged with `sunos` are still called "Solaris", all other references to "SunOS" have been renamed. See：https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 Follow up PR to #1989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1987
I didn't change the text 'SunOS xx-Bit Binary' in all the release blog posts, as I don't know when the naming change SunOS -> SmartOS happened and if we ever had binaries compatible with all systems derived from SunOS.
/cc @rvagg: Could you please give me a +1/-1 for renaming them as well?