Skip to content

Update dependencies#1098

Merged
phillipj merged 1 commit into
masterfrom
update/dependencies
Jan 12, 2017
Merged

Update dependencies#1098
phillipj merged 1 commit into
masterfrom
update/dependencies

Conversation

@lpinca

@lpinca lpinca commented Jan 7, 2017

Copy link
Copy Markdown
Member

@yorkie

yorkie commented Jan 7, 2017

Copy link
Copy Markdown
Contributor

@lpinca html-to-text is a semver-major upgrade, a simple description about why we need this patch and risks?

@lpinca

lpinca commented Jan 7, 2017

Copy link
Copy Markdown
Member Author

@yorkie AFAIK the only breaking change there is the switch to htmlparser2. It should have no side effects for us.

@lpinca

lpinca commented Jan 7, 2017

Copy link
Copy Markdown
Member Author

html-to-text is only used in the event-geo.js script to have a "text" description of the events in the map of the events page.

@ryanmurakami ryanmurakami left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipj phillipj merged commit ba7b2e2 into master Jan 12, 2017
@phillipj phillipj deleted the update/dependencies branch January 12, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants