chore: Run prettier/tslint in ci #97
Conversation
ollelauribostrom
force-pushed
the
prettier-travis
branch
3 times, most recently
from
e2379ac to
c15d74b
Compare
|
Since #90 got merged, I ran prettier here to format all of the files according to the new set of rules 💅 |
|
@ollelauribostrom We definitely need that but I'd like to wait until the next meeting so we all can agree on the current prettierrc. Would like to avoid clutter up git history with syntax back and forth. |
|
@ollelauribostrom This looks good. Can we rebase against upstream and run prettier again? The prettier rules were recently updated in #153. |
|
@sagirk I'm on it! 🙂 |
|
@sagirk @ollelauribostrom Can we please wait with that for a while. I'll open a big refactoring PR would be quite painful to resolve syntax conflicts :[ |
|
@LaRuaNa Yep sure sounds like a good idea 👍 |
|
@ollelauribostrom #157 is finally merged. 🎉 |
ollelauribostrom
force-pushed
the
prettier-travis
branch
from
c15d74b to
ef0b278
Compare
|
@sagirk This should now be up to speed with master. Not sure why the travis build fails, everything works as expected locally 🤔 Any ideas? |
|
Just to tidy up a bit and prevent double work: Here an issue https://github.com/nodejs/nodejs.dev/issues/164 about prettier hooks. And I'm working on linter / prettier integration with industry standards like airbnb config as decided in the last meeting |
|
Just make a small change to fix @MylesBorins @LaRuaNa PTAL. (BTW, we are still ok to wait with your big refactoring PR if needed :) |
sagirk
left a comment
sagirk
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Thanks @ollelauribostrom! ❤️
|
Landing this now. https://github.com/nodejs/nodejs.dev/issues/164 can follow after this. #179 might need some more time to be fully fleshed out. |
5 participants
Summary of changes:
format-checkandtslintscripts to package.jsonformat-checkandtslintscripts in Travis CINote:
Running
yarn format-checkwill currently fail with exit code 1 since a bunch of files aren't formatted correctly (this is what's causing the build for this PR to fail). Once we have decided on some formatting rules (#90) and the project is formatted in a unform way, this will work as a guard for not merging code that isn't correctly formatted or that is missing type annotations etc.