-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
is that tabs instead of spaces??? Not to start the bikeshed, but unmmmm please spaces, width of 2 also no trailing commas... I'm good with everything else |
|
I would like to propose using a smaller print width (80 seems to be recommended here). Makes stuff a bit easier to read in my opinion 🤓 |
|
@MylesBorins Sure thing. Now using @ZYSzys Consistent rules applied. @ollelauribostrom PR ready for review/merge. Peace! ✌️ |
ZYSzys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We wanna talk about that in the next Meeting #44 |
|
@MylesBorins this good enough for merge now? 🤔 |
|
@LaRuaNa are you open to us landing this now, while we don't have many open PRs, and iterate again based on results of the upcoming meeting? |
MylesBorins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@MylesBorins Yep, let's do that. I leave the #44 open so we can come back if needed. |
As per the discussion in today's meeting, this is the new set of rules as discussed based on #90. Looking forward, peace! ✌️ Fixes: #44
As per the discussion in #68 I'd like to propose the following formatting changes. These are all up for debate and currently represent my personal preference with prettier and nothing more.
Looking forward, peace! ✌️