Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@ahmadawais
Copy link
Member

@ahmadawais ahmadawais commented Feb 20, 2019

As per the discussion in #68 I'd like to propose the following formatting changes. These are all up for debate and currently represent my personal preference with prettier and nothing more.

Looking forward, peace! ✌️

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 20, 2019

"useTabs": true

is that tabs instead of spaces??? Not to start the bikeshed, but unmmmm please spaces, width of 2

also no trailing commas... I'm good with everything else

@ollelauribostrom
Copy link
Contributor

I would like to propose using a smaller print width (80 seems to be recommended here). Makes stuff a bit easier to read in my opinion 🤓

@ahmadawais
Copy link
Member Author

@MylesBorins Sure thing. Now using spaces with 2 set as width.

@ZYSzys Consistent rules applied.

@ollelauribostrom 80 is actually way too short but maybe it's me — moved it back to 80.

PR ready for review/merge.

Peace! ✌️

Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaRuaNa
Copy link
Contributor

LaRuaNa commented Feb 21, 2019

We wanna talk about that in the next Meeting #44

@ahmadawais
Copy link
Member Author

@MylesBorins this good enough for merge now? 🤔

@MylesBorins
Copy link
Contributor

@LaRuaNa are you open to us landing this now, while we don't have many open PRs, and iterate again based on results of the upcoming meeting?

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaRuaNa
Copy link
Contributor

LaRuaNa commented Feb 22, 2019

@MylesBorins Yep, let's do that. I leave the #44 open so we can come back if needed.

@LaRuaNa LaRuaNa merged commit abad22c into nodejs:master Feb 22, 2019
ahmadawais pushed a commit that referenced this pull request Mar 1, 2019
As per the discussion in today's meeting, this is the new set of rules as discussed based on #90. Looking forward, peace! ✌️

Fixes: #44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants