Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Feat/releases page#843

Closed
saulonunesdev wants to merge 77 commits into
nodejs:masterfrom
saulonunesdev:feat/releases-page
Closed

Feat/releases page#843
saulonunesdev wants to merge 77 commits into
nodejs:masterfrom
saulonunesdev:feat/releases-page

Conversation

@saulonunesdev

@saulonunesdev saulonunesdev commented Aug 12, 2020

Copy link
Copy Markdown

Description

Releases/Download Page #261 #547

Related Issues

amiller-gh and others added 30 commits September 7, 2019 11:48
* feat: API Docs preview and version switcher
* feat: Add design tokens and style-guide page (nodejs#311)
* feat: API Docs preview and version switcher
* feat: API Page Types
* feat: Light/dark toggle in nav
 - Add API Summary section at top of page
 - Fix dark mode on learn page
 - Add all API doc sections
 - Fix API object typings
* chore: Eslint / Prettier integration.

* chore: Change ext order to overwrite eslint rules

* chore: Add build to gitignore

* chore: Eslint fixes after config change

* chore: Update yarn.lock after rebase

* chore: Add eslint-plugin-jest and extend w/ reccs

* chore: Disable no-var-requires for .js files

* chore: Remove format-check from test script

* chore: Fix eslint errors in js files

* chore: Update husky pre-push to use lint script

* chore: Create new .eslintrc config

* chore: Update lint script, add react settings to eslint config

* chore: Ignore test dir when running lint script

* chore: Add airbnb config and jest env to eslintrc

* chore: Disable react/jsx-filename-extension

* chore: Recover .prettierrc config file that was deleted

* chore: Extend eslint config with prettier/react

* chore: Fix all but a few eslint errors

* chore: Update eslint-plugin-prettier

* chore: Disable prefer-default-exports rule

* chore: Fix eslint errors after merging with staging

* chore: Fix eslint errors in konami code

* chore: Disable import/extensions and consistent-return rules

* chore: Set return type for setPage hook in click handler to void

* fix: Clean up some errors after all the merge fixing
* fix: Only disable next line for react/danger in article
* feat: Create ReleaseToggle component
* feat: Create ReleaseCards component
* chore: Add material-design placeholder icons to release cards
* feat: Create and use detectOS util function
* fix: Check if navigator is defined before using, fixes ssr
* feat: Enhanced Dark Mode Toggle Features

This adds a new `utils/DarkModeController` controller wrapped in a new `components/controls` component.
I'm not a huge fan of the current text:

"The power of JavaScript minus the browser"

This is inaccurate as Node.js is offering a ton of interfaces and
support e.g. system IO that the Browser doesn't offer. Also, while it
is not a browser I do like to think of Node.js as an active participate
in the Web Platform... the comparison here has a negative charge that I
don't think does us any benefit.
* feat: Add Footer component to layout

* test: Add Test for Footer component

* test: Updated snapshots changed by Footer component

* style: Add right margin to footer links and refactored styles

* feat: Add blur event to dropDown
Summary: Add onBlur event to dropDownButton so the user can click
anywhere outside of dropdown menu to close it

* test: Update footer snapshot

* chore: Move eslint ingore pattern from package.json
to .eslintignore

* fix: Fixed onBlur event firing even if dropdown is closed

* chore: Removed Emoji Flags from footer dropdown
        Emoji flags are not supported by all platforms, E.g. On windows

Co-authored-by: Ben Halverson <benhalverson33@gmail.com>
* docs(contributing.md): Added details on how to contribute

#396

* docs(contributing.md): Updated the getting started section
* feat(banner): Added a new banner component

#332

* style(banner.tsx): Added additional styling

Added additional styling to match the mockup more closely

* test(snapshot): Updated snapshot for banner.tsx

* Fix topbanner dark mode (#1)

* fix: Banner styling for dark mode

* test(snapshot): Updated snapshot for banner.tsx

* style: Lint

Co-authored-by: Saleh Abdel Motaal <saleh@smotaal.io>
* fix(banner.tsx): Set border property to bannerButton css to avoid border styles from browsers user agent stylesheet

* fix(banner.tsx): Set transparent as border color

* fix(banner.tsx): Update banner.tsx snapshot
benhalverson and others added 19 commits May 6, 2020 17:03
* feat(homepage): Added how to install tabs

* refactor(homepage): Refactored some styling for the install tabs

* test(install tabs): Added a snapshot for a the installTabs component

* refactor(install tabs): More styling for the install text

* docs(readme): Remove random test2 text from readme

* feat(install-tabs): Styling the tabs

* test(snapshot): Updated snapshot for install-tabs component

* feat(homepage): Added how to install tabs

* refactor(homepage): Refactored some styling for the install tabs

* test(install tabs): Added a snapshot for a the installTabs component

* refactor(install tabs): More styling for the install text

* docs(readme): Remove random test2 text from readme

* feat(install-tabs): Styling the tabs

* test(snapshot): Updated snapshot for install-tabs component
* chore: Remove my editor settings from git radar

* chore: Add marketing vector images

* chore: Replace dummy markting text and images

* chore: Move Banner import decleartion to the top

* chore: Fix merge conflict

* chore: Add marketing details and styles
Signed-off-by: bhumijgupta <bhumijgupta@gmail.com>
@benhalverson

Copy link
Copy Markdown
Member

/preview

@benhalverson benhalverson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/843/

@jemjam

jemjam commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

It looks like this still needs a little more cleanup to be mergeable.

@designMoreWeb designMoreWeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benhalverson benhalverson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up the extra commits and unrelated files.

@saulonunesdev

Copy link
Copy Markdown
Author

This will be merged in #912

@saulonunesdev saulonunesdev deleted the feat/releases-page branch September 9, 2020 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.