Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Update contributing.md from staging to master #697

Merged
benhalverson merged 8 commits into from
May 7, 2020
Merged

Update contributing.md from staging to master #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c7626ec
refactor(.gitignore): Added .env.production to .gitignore
benhalverson Mar 30, 2020
778a0a5
Merge branch 'master' of github.com:nodejs/nodejs.dev
benhalverson Apr 20, 2020
a6ec024
Merge branch 'master' of github.com:nodejs/nodejs.dev
benhalverson Apr 25, 2020
5e4c6d5
Merge branch 'master' of github.com:nodejs/nodejs.dev
benhalverson Apr 27, 2020
d621934
Merge branch 'master' of github.com:nodejs/nodejs.dev
benhalverson May 5, 2020
243158f
Merge branch 'master' of github.com:nodejs/nodejs.dev
benhalverson May 5, 2020
95d5a03
docs(contributing.md): Added details on how to contribute (#397)
benhalverson Feb 29, 2020
45ef6bb
docs(contributing.md): Fixed markedown linting errors
benhalverson May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ yarn-error.log
.DS_Store

.env
.env.production
.firebase/*
coverage
.vscode
Expand Down
16 changes: 16 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,22 @@ In the case of an objection being raised in a pull request by another collaborat
* [`squash`][] pull-requests made up of multiple commits
* Land how you like as long as there are no merge commits

## Getting Started

For feature development you should be working from the staging branch.

* Fork
* Clone your fork `git clone git@github.com:<githubid>/nodejs.dev.git`
* cd into your project
* Add the following to your remotes by doing `git remote add upstream git@github.com:nodejs/nodejs.dev.git`
* Check out the staging branch by doing `git checkout upstream/staging`
* Create a new branch for your awesome work `git checkout -b branchname`
* Commit your work
* Push to your branch `git push -u origin yourbranch`
* Make a pull request against the remote branch `staging`
* Example `https://github.com/nodejs/nodejs.dev/pull/398`
* Mention @nodejs/website-redesign `/gcbrun`
Copy link
Contributor

@giankotarola giankotarola May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need to use /preview instead of /gcbrun?

Copy link
Member Author

@benhalverson benhalverson May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ya forgot about that change.


## Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:
Expand Down