This repository was archived by the owner on Apr 26, 2024. It is now read-only.
test: Navigation, NavigationItem, NavigationSection #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalverson
suggested changes
May 6, 2020
Member
benhalverson
left a comment
benhalverson
left a comment
There was a problem hiding this comment.
Thank you for the contribution 👍
Can you address the new linter warnings.
src/components/NavigationItem/__tests__/navigation-item.test.tsx
Outdated
Show resolved
Hide resolved
src/components/NavigationItem/__tests__/navigation-item.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
Updated the PR ✅ |
Contributor
Author
Hey @benhalverson , any other issues I can pick, will be interested to contribute more 😄 |
Member
|
Ya some things that need to be done are
Tomorrow is our bi-weekly zoom meeting feel free to join #681 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sanity test cases for for Navigation, NavigationSection & NavigationItem. Add up to the coverage.
Related Issues
Addresses #409