This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Sanity test cases for for Navigation, NavigationSection & NavigationItem#695
Closed
tstreamDOTh wants to merge 162 commits into
Closed
Sanity test cases for for Navigation, NavigationSection & NavigationItem#695tstreamDOTh wants to merge 162 commits into
tstreamDOTh wants to merge 162 commits into
Conversation
- Improve grammar for **Node.js Frameworks and Tools** section of the page. - Replaced all `commas` by `colon`. - Added links for all the libs in the `Meteor` point since a link for `Vue` was present.
Also fix one point that continues at the end of another
* tools: remove husky I've honestly felt this has introduced more friction then what it helps us accomplish. Not convinced that consistent commit messages matter a ton on the site, especially since we are not doing anything with the commit messages e.g. changelog Fixes: https://github.com/nodejs/nodejs.dev/issues/321
Also consistent with EditorConfig
Cleaned up other minor whitespace issues at the same time
- Github -> GitHub - Javascript -> JavaScript - Delete "Note that" - node.js -> Node.js
Replace tabs with spaces to match EditorConfig as well
The dashes directly under the text get interpreted as a heading style
add link to [V8 website](https://v8.dev/) and [Standard ECMA-262](https://www.ecma-international.org/publications/standards/Ecma-262.htm)
Bumps [npm](https://github.com/npm/cli) from 6.11.2 to 6.13.4. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v6.11.2...v6.13.4) Signed-off-by: dependabot[bot] <support@github.com>
Results of yarn upgrade gatsby. This will quell a warning in the GitHub interface.
Supress newly failing rules to be fixed separatley
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
In the copy a buffer section, there is a mistake: buf.copy(bufcopy, 0, 2,2) //it will print nothing since the source start and source end is specified as 2 in the original code correction: buf.copy(bufcopy, 0, 0, 2) // it will print the desired output that is 'He'
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Add a note (condition) for running the `node.js` command.
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
…#384) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Myles Borins <mylesborins@google.com>
Co-authored-by: Alexandr Tovmach <alexandrtovmach@gmail.com> Co-authored-by: Myles Borins <mylesborins@google.com>
Co-authored-by: Myles Borins <mylesborins@google.com>
…js#641) Bumps [gatsby-transformer-remark](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/gatsby-transformer-remark) from 2.7.5 to 2.8.0. - [Release notes](https://github.com/gatsbyjs/gatsby/releases) - [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-remark/CHANGELOG.md) - [Commits](https://github.com/gatsbyjs/gatsby/commits/gatsby-transformer-remark@2.8.0/packages/gatsby-transformer-remark) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
) Bumps [gatsby-plugin-manifest](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/gatsby-plugin-manifest) from 2.3.7 to 2.4.0. - [Release notes](https://github.com/gatsbyjs/gatsby/releases) - [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-manifest/CHANGELOG.md) - [Commits](https://github.com/gatsbyjs/gatsby/commits/gatsby-plugin-manifest@2.4.0/packages/gatsby-plugin-manifest) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Alexandr Tovmach <alexandrtovmach@gmail.com>
Bumps [gatsby-remark-prismjs](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/gatsby-remark-prismjs) from 3.4.5 to 3.5.0. - [Release notes](https://github.com/gatsbyjs/gatsby/releases) - [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-remark-prismjs/CHANGELOG.md) - [Commits](https://github.com/gatsbyjs/gatsby/commits/gatsby-remark-prismjs@3.5.0/packages/gatsby-remark-prismjs) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Alexandr Tovmach <alexandrtovmach@gmail.com>
* Initial draft of socket prog guide * Updates * fix linting * Update src/documentation/0000-socket-programming-with-net-module/index.md Co-Authored-By: Myles Borins <myles.borins@gmail.com> * Update src/documentation/0000-socket-programming-with-net-module/index.md Co-Authored-By: Myles Borins <myles.borins@gmail.com> * Update src/documentation/0000-socket-programming-with-net-module/index.md Co-Authored-By: Myles Borins <myles.borins@gmail.com> * add links Co-authored-by: Myles Borins <myles.borins@gmail.com>
Co-authored-by: Myles Borins <mylesborins@google.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.0.4 to 2.0.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@2.0.4...2.0.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Ben Halverson <7907232+benhalverson@users.noreply.github.com>
Co-authored-by: Ben Halverson <7907232+benhalverson@users.noreply.github.com>
Bumps [tslint](https://github.com/palantir/tslint) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/palantir/tslint/releases) - [Changelog](https://github.com/palantir/tslint/blob/master/CHANGELOG.md) - [Commits](palantir/tslint@6.1.1...6.1.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…js#678) Bumps [gatsby-transformer-remark](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/gatsby-transformer-remark) from 2.8.0 to 2.8.5. - [Release notes](https://github.com/gatsbyjs/gatsby/releases) - [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-remark/CHANGELOG.md) - [Commits](https://github.com/gatsbyjs/gatsby/commits/gatsby-transformer-remark@2.8.5/packages/gatsby-transformer-remark) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [gatsby](https://github.com/gatsbyjs/gatsby) from 2.20.29 to 2.21.11. - [Release notes](https://github.com/gatsbyjs/gatsby/releases) - [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/CHANGELOG.md) - [Commits](https://github.com/gatsbyjs/gatsby/compare/gatsby@2.20.29...gatsby@2.21.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Contributor
Author
|
@benhalverson Some coverage 🙂 |
Member
|
Thanks for writing some tests @tstreamDOTh |
Contributor
Author
|
@benhalverson Raised it on staging - #696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sanity test cases for for Navigation, NavigationSection & NavigationItem. Add up to the coverage.
Related Issues
Addresses #409