This repository was archived by the owner on Apr 26, 2024. It is now read-only.
docs: Fix Promise error handling examples#680
Merged
Conversation
Trott
approved these changes
May 4, 2020
db6f163 to
3eb4beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tweaked function calls in examples in "Exceptions with promises" section to reduce possible confusion vectors:
doSomething1is a function that returns aPromisein both examplesdoSomething2anddoSomething3should not be called until thedoSomething1promise resolves if they return aPromiseor the chain will be broken.thenThis will result in correct order: AA (after 2s) -> BB (after 3s)
But this won't (as promise is scheduled immediately): BB (after 1s) -> AA (after 2s)