Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

refactor: SEO Meta & Formatting.#67

Closed
ahmadawais wants to merge 4 commits into
nodejs:masterfrom
ahmadawais:master
Closed

refactor: SEO Meta & Formatting.#67
ahmadawais wants to merge 4 commits into
nodejs:masterfrom
ahmadawais:master

Conversation

@ahmadawais

Copy link
Copy Markdown
Member

Hey, folks! 🙌

Would love to be involved in the project. First PR here.

This PR does a couple of related things:

  • refactors SEO meta description to replace placeholder info with real
  • refactors the header to remove meta keywords which are generally not required
  • fixes formatting that was done by running npm run format as per the project settings

Looking forward, peace! ✌️

@ahmadawais

Copy link
Copy Markdown
Member Author

Kindly, consider this an immediate fix since the site is live and the meta with placeholder info doesn't look good.

I'd also like to take the responsibility to build the entire SEO/SMM related data inside here which is controlled by a single config file.

@MylesBorins

Copy link
Copy Markdown
Contributor

/gcbrun

@MylesBorins

Copy link
Copy Markdown
Contributor

@ahmadawais could you please remove the commit to refactor / prettify the code, it introduces a lot of noise and will create conflicts for other PRs

@MylesBorins

Copy link
Copy Markdown
Contributor

@ahmadawais

Copy link
Copy Markdown
Member Author

@MylesBorins Thanks for the review — I went ahead and refactored the entire SEO component instead of this PR so closing it in the favor of PR #68

Peace! ✌️

@ahmadawais ahmadawais closed this Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants